Fix out of memory errors causing logic_error when using ManagedRandomAccessFile #471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of the
ManagedRandomAccessFile
methods called from C++ caused anOutOfMemoryException
, the exception message was set tonull
inHandleException
, but this caused astd::logic_error
on the C++ side when trying to convertnullptr
tostd::string
when constructing anarrow::Status
inManagedRandomAccessFile::GetResult
. The error looks like:I've added a check for
exception == nullptr
to fix this.I've also changed the
TRYCATCH
macro so that these errors are propagated out as anOutOfMemoryException
again, and fixed the use of plain integers for status codes.