Bump version of macos used to build the native library #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macos-11 images are being deprecated, see failures due to the brownout in https://github.com/G-Research/ParquetSharp/actions/runs/9643175788.
I've just bumped to macos-12 rather than 13 or the ARM based macos-14 images as I'm not certain whether a native library built on macos would be compatible with older versions. It sounds like we might be able to work around that by setting the
MACOSX_DEPLOYMENT_TARGETenvironment variable but I'm not familiar with building on mac.