Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specifying version-suffix parameter in CI build #463

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Jun 23, 2024

For some reason:

dotnet build csharp --version-suffix="something"

is ok, but

dotnet build csharp --version-suffix=""

fails with "Required argument missing for option: '--version-suffix'." (see https://github.com/G-Research/ParquetSharp/actions/runs/9636767326/job/26575196786)

We need to instead use:

dotnet build csharp --version-suffix ""

@adamreeve adamreeve merged commit 9372d5f into G-Research:master Jun 24, 2024
36 checks passed
@adamreeve adamreeve deleted the ci_fix branch June 24, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants