Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for vcpkg binary caching #457

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

jgiannuzzi
Copy link
Member

@jgiannuzzi jgiannuzzi commented Jun 10, 2024

This PR switches our CI to use a more granular approach to vcpkg binary caching. It uses the GitHub Actions Cache feature of vcpkg to cache individual packages instead of the all-or-nothing blob approach we were using. The huge advantage is that any package that gets properly built gets cached, even if the workflow does fail at some point in time. The other advantage is that we don't need to keep updating our cache keys to try to match the vcpkg ABI mechanism, but can instead let vcpkg do its thing.

Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good thanks Jonathan

@jgiannuzzi jgiannuzzi merged commit 79ca0f1 into G-Research:master Jun 10, 2024
31 checks passed
@jgiannuzzi jgiannuzzi deleted the vcpkg-gha-caching branch June 10, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants