Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow getting a ParquetFileReader and the SchemaManifest from an Arrow.FileReader #430

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Mar 19, 2024

  • This allows getting a ParquetFileReader from an Arrow.FileReader, which might be required if you want to access things like the row group statistics
  • In order to allow this in a safe way, I've added a new ChildParquetHandle class that holds a pointer to an object that is owned by some other disposable object, and added a new INativeHandle interface to support using either a ParquetHandle or ChildParquetHandle. There are other places in the code where we might want to use this, eg. the RowGroupMetaData returned from a RowGroupReader is one I noticed, but that should probably be a separate PR. See also Missing dispose of RowGroupMetaData in RowGroupReader? #322
  • Additionally, to be able to interpret the Parquet metadata when the file has a complex nested structure, expose the SchemaManifest associated with a FileReader

@adamreeve adamreeve marked this pull request as ready for review March 20, 2024 08:48
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@adamreeve adamreeve merged commit c98ee2b into G-Research:master Mar 21, 2024
30 checks passed
@adamreeve adamreeve deleted the arrow_get_underlying_reader branch March 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants