Fix segfault writing to no longer valid column writer #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
commented
Nov 26, 2023
| @@ -159,7 +159,25 @@ public LogicalColumnWriter<TElement> LogicalWriterOverride<TElement>(int bufferL | |||
| protected static extern unsafe IntPtr TypedColumnWriter_WriteBatchSpaced_FixedLenByteArray( | |||
| IntPtr columnWriter, long numValues, short* defLevels, short* repLevels, byte* validBits, long validBitsOffset, FixedLenByteArray* values); | |||
|
|
|||
| protected readonly IntPtr Handle; | |||
| protected IntPtr Handle | |||
There was a problem hiding this comment.
I don't believe we need to worry about binary compatibility here, because Handle is a protected member and the ColumnWriter and ColumnWriter<TValue> constructors are both internal, so it shouldn't be possible for code outside of ParquetSharp to be accessing this member.
marcin-krystianc
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400