Dispose of most uses of LogicalType and Node #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
commented
Jul 4, 2022
| { | ||
| } | ||
|
|
||
| public ParquetFileReader(string path, ReaderProperties readerProperties) | ||
| public ParquetFileReader(string path, ReaderProperties? readerProperties) |
There was a problem hiding this comment.
Nullability of reference types isn't part of the binary method signature so this is ABI compatible as well as source compatible.
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
marcin-krystianc
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've tried to dispose of most internal uses of LogicalType and Node to reduce the need to run finalizers.
There is still one main place where we create logical types and nodes that aren't disposed that I'm aware of. In LogicalColumnStream, the LogicalType and SchemaNodesPath properties are initialized in the constructor rather than being getters that create new instances, so these should probably be disposed when disposing the LogicalColumnStream instance. But there's a small chance that could be a breaking change if somebody is expecting to be able to continue using those after the LogicalColumnStream is disposed, so I've currently left that as-is.
There's also
RowOriented.ParquetFile.GetColumnwhich creates logical types that aren't disposed, and I couldn't see a straightforward way to fix that.