Build linux-x64 in a CentOS 7 container for backwards compatibility #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreeve
approved these changes
May 24, 2022
|
Indeed it would be a bit more complex and with no real advantage as it's already faster than the Windows build, which is usually the last to finish before we can move on with the workflow. |
|
I think there is one small issue here with vcpkg caching and the cmake version. We will use runner's cmake version as part of the cache key, but the actual compilation occurs on the CentOS which uses different cmake. |
|
@marcin-krystianc we install the same version of cmake in the container as on the host for that exact reason |
Ah, indeed. I've missed that. Perfect! |
marcin-krystianc
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at fixing #273 by building the linux-x64 native library within a CentOS 7 container with GCC 7. This allows linking with older versions of the system libraries, widening the Linux distributions supported by our NuGet package.
Please note that the linux-arm64 native library is still built on Ubuntu 18.04, as there is no recent cross-compiler available on CentOS 7. We will probably need to first get self-hosted linux-arm64 runners before we can support this. All of this being said, I don't expect many people to use old Linux distributions on arm64.