Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tape tests with node test runner #10

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Replace tape tests with node test runner #10

merged 3 commits into from
Feb 24, 2023

Conversation

G-Ray
Copy link
Owner

@G-Ray G-Ray commented Feb 24, 2023

  • Removed tape
  • Rewrote tests with NodeJS test runner, using describe/it syntax.
  • Removed dependencies between tests by instantiating/closing transmission instance beforeEach/afterEach.
    Closes Revamp tests #6

@G-Ray G-Ray requested a review from tony-go February 24, 2023 13:58
@G-Ray G-Ray linked an issue Feb 24, 2023 that may be closed by this pull request
@@ -7,7 +7,7 @@
"main": "index.js",
"scripts": {
"install": "node-gyp-build",
"test": "standard && tape test.js",
"test": "standard && node --test test.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

test.js Outdated Show resolved Hide resolved
test.js Show resolved Hide resolved
G-Ray and others added 2 commits February 24, 2023 15:28
Co-authored-by: Tony Gorez <gorez.tony@gmail.com>
@G-Ray
Copy link
Owner Author

G-Ray commented Feb 24, 2023

I removed the trash emoji as it seems we encounter a bug similar to nodejs/node#45706

@G-Ray G-Ray merged commit 76e9168 into master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp tests
2 participants