-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Python2 crumbs #541
Conversation
Hi Alexandre, Thanks for your QA work, I'll try to not forget about the python3-six package once removed upstream; I left a Fixme item in the d/control file so lintian will ring some alarm bells for me when the time will come. Have a nice day, :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
uh, seems I was a little too fast with my approval...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this to our attention and doing a lot of the work to clean it up. There appear to be a few issues with iterating on a single type (see inline comment).
I'd also love to see this PR split into multiple commits if it's not too much trouble. For example, the changes in setup.py
could be their own commit.
I understand if you don't have time to work on this and perhaps this was meant as a quick patch to make the project buildable for the distro and bring it up to date a bit, so let us know and we can take it from here if necessary.
I'm out for the day :-) You can merge as-is if you like it of course. |
I on Holliday for one week. Do you still need my help before merging this ? |
Hi @a-detiste, just enjoy your holidays :) |
Hi !
I saw this new package in Debian today popping up in my QA list.
Here's a cleanup of Python2 code.
@emollier : please remove python3-six dependency when a new release is published, or I'll do if I notice first
https://tracker.debian.org/pkg/python-nixio
https://salsa.debian.org/detiste-guest/python3-six-removal/-/commit/b3218f61adb31c09cac2de735fd83997abe9b707