-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Replace hmm
with HxPKG
#3741
base: develop
Are you sure you want to change the base?
Conversation
That issue happens because hxCodec needs to be installed globally, by the way |
It doesn't need to be installed globally
|
woah its real i haven't tested installing hxCodec with hxpkg |
I'm pretty sure that's been resolved internally already anyway HaxeFoundation/haxelib#618, although seems like we'll still have to deal with it for a while: polybiusproxy/hxCodec#300 (comment) |
haxe moment |
You can't do that with hmm |
This PR uses HxPKG, so, it'll be a thing for HxPKG, not for hmm |
Extra info |
HxPKG should hopefully force hxCodec to be installed globally if detected within .hxpkg This is a temporary fix until Haxe 5.0 comes out |
hxCodec is always installed globally through hxpkg |
If someone could teach me how to re-base (so I can delete that pesky CHANGELOG commit) and sync branches from the correct branch, that'd be fuckin' wonderful LOL |
@ninjamuffin99 sorry for the @, but, since you're the Git guru around here, is there a way you can fix the "duplicate" commits from appearing? |
7cf45de
to
558b05a
Compare
Squashed the commits, did a few changes, this should be a-okay now! |
Co-authored-by: CobaltBar <79053181+CobaltBar@users.noreply.github.com> Co-authored-by: lemz1 <ismael.amjad07@gmail.com>
Keeping the cache in, as that's important, but the setup isn't, as HxPKG automatically sets up hxcpp for you
Does this PR close any issues? If so, link them below.
#2341
Briefly describe the issue(s) fixed.
Should remedy issues with the compiler reporting that libs are missing, when they aren't, just like the issue above.
Brief description
HxPKG
, just likehmm
, is a Haxe library/module manager that installs libraries with a singular command, locally.Difference between
hmm
andHxPKG
is that it's self contained, meaning it doesn't other dependencies to work, it's regularly maintained, it automatically sets uphxcpp
without external commands or user input, etc.For more commands on how to use HxPKG, read here.
If you guys have anything to report, you can report it here or make an issue on @CobaltBar's HxPKG repo here.
Changelog:
hmm
withHxPKG
HxPKG
(it's pretty similar)HxPKG
HaxelibVersions.hx
to work withHxPKG
Constants.hx
to sayHxPKG
and nothmm
😝TROUBLESHOOTING.md
funkin.art
andfunkin.assets
Important
Please do double check if all the workflow files and edited source code files work properly, as far as we're concerned, they should be fine.
Special Thanks
@CobaltBar for HxPKG
@lemz1 for editing the macros to work with HxPKG
Include any relevant screenshots or videos.
N/A