[BUGFIX] Fix Audio/Visual Offset causing skips on song start #3732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use combined offset here-- using it will cause the instrumental to skip forwards due to your offset. Just use instrumental offset, and don't play it when the song starts-- let resyncVocals do that
Conductor's minimum songPosition when music is playing is now combinedOffset. resyncVocals is also altered a smidge due to the fact that we don't want to apply offsets when resyncing at the start + we don't want to play the music and THEN resync because it makes the sound double up when lag happens on start and it sounds ugly
Throw resyncVocals out of startSong because it complicates matters
github-actions
bot
added
medium
xenkap
changed the title
|
Currently a weird awkward pause after the countdown before the song plays. Currently investigating |
xenkap
changed the title
+ mild fixes
|
okay all good :yippe: |
github-actions
bot
added
the
medium
|
added footage :D |
cyn0x8
approved these changes
Oct 30, 2024
thank you https://github.com/cyn0x8 for reminding me FlxMath.bound exists Co-authored-by: cyn <cyn0x8+git@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the song previously utilized combinedOffset to offset where in the song the instrumental starts in.
This is no longer the case, instead using instrumentalOffset for starting.
The Conductor and Countdown classes have been altered to reflect this behavior.
function startSong also no longer uses resyncVocals().
It was kind of pointless being there, and needing to play the instrumental before calling it makes the audio double up sometimes and it sounds awful
Does this PR close any issues? If so, link them below.
[TBA, but quick searches about offset don't show much]
Briefly describe the issue(s) fixed.
Audio used to skip forward when negative values of Audio/Visual Offset were present. This is now fixed, along with ugly audio doubling behavior on start.
Include any relevant screenshots or videos.
BEFORE:
2024-10-19.17-06-43.mp4
AFTER:
2024-10-19.17-04-39.mp4
(recorded on -210ms audio/visual offset. yes my headphones are that bad, yes they are bluetooth)