Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Don't restart the FreeplayState song preview when changing the difficulty within the same variation #3587

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[BUGFIX] Don't restart the FreeplayState song preview when changing the difficulty within the same variation #3587

merged 1 commit into from
Oct 8, 2024

Conversation

KoloInDaCrib
Copy link
Contributor

@KoloInDaCrib KoloInDaCrib commented Oct 5, 2024 •
edited
Loading

Does this PR close any issues? If so, link them below.

3583

Briefly describe the issue(s) fixed.

Modifies the changeDiff function inside FreeplayState to account for changing variations.

Include any relevant screenshots or videos.

2024-10-05.10-27-14.mp4

@github-actions github-actions bot added pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. size: small A small pull request with 10 or fewer changes. and removed size: large A large pull request with more than 100 changes. labels Oct 5, 2024
trayfellow
trayfellow approved these changes Oct 5, 2024
View reviewed changes
Copy link

@trayfellow trayfellow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuuuu

Also it would be cool if this could apply for the volume when your still selecting Random

@amyspark-ng
Copy link
Contributor

thank you

@KoloInDaCrib @ninjamuffin99
fix: Don't restart the FreeplayState song preview when changing the d…
b0fc474 
…ifficulty within the same variation

pulled from the wrong branch, oops!

last update i hope

wrong spellings im gonna kms
@ninjamuffin99 ninjamuffin99 force-pushed the freeplay-changeDiff-fix branch from 9fc8f61 to b0fc474 Compare October 8, 2024 17:55
@ninjamuffin99 ninjamuffin99 merged commit 903b3fc into FunkinCrew:develop Oct 8, 2024
2 checks passed
@ninjamuffin99
Copy link
Member

thank u very much very nice and awesom :)

@KoloInDaCrib
Copy link
Contributor Author

thank u very much very nice and awesom :)

Thankyouse

@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Oct 12, 2024
@KoloInDaCrib KoloInDaCrib deleted the freeplay-changeDiff-fix branch November 30, 2024 12:54
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biomseed biomseed biomseed approved these changes

@trayfellow trayfellow trayfellow approved these changes

@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.
8 participants
@KoloInDaCrib @amyspark-ng @ninjamuffin99 @NotHyper-474 @trayfellow @biomseed @EliteMasterEric @Hundrec