[BUGFIX] A-Bot now reacts to volume on desktop #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesisfeline
approved these changes
Sep 28, 2024
AppleHair
approved these changes
Sep 28, 2024
EliteMasterEric
added
the
status: pending triage
|
What happens if you apply the inverse of this to the web version instead? |
Using this line (which I assume is the inverse): animFrame = Math.round(animFrame / (Math.round(FlxG.sound.logToLinear(FlxG.sound.volume) * 10) / 10));ormfroptmgtopymgportmgprot.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Yes, #3400
Briefly describe the issue(s) fixed.
A-Bot now reacts to volume on desktop version however it's not perfect and doesn't look exactly the same as the web version, but it does look better than the previous implementation
Include any relevant screenshots or videos.
a-bot.mp4