Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX + REFACTOR] ChartEditor Live Input #2992

Merged
merged 3 commits into from
Sep 16, 2024
Merged

[BUGFIX + REFACTOR] ChartEditor Live Input #2992

merged 3 commits into from
Sep 16, 2024

Conversation

gamerbross
Copy link
Contributor

(Omg this code was awful 😭)
Big refactor of the live input system that also fixes #2988

@gamerbross gamerbross changed the base branch from main to develop July 9, 2024 23:29
@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. type: minor bug Involves a minor bug or issue. status: reviewing internally This PR is under internal review and quality assurance testing chart editor Issue is related to the operation of the Chart Editor. medium A medium pull request with 100 or fewer changes and removed status: pending triage The bug or PR has not been reviewed yet. labels Jul 10, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric
Copy link
Member

Works great for me

@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Jul 12, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit 081d2d8 into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/charteditor-liveinput-number-6 branch September 25, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

@NotHyper-474 NotHyper-474 NotHyper-474 approved these changes

@anysad anysad anysad approved these changes

@tposejank tposejank tposejank approved these changes

@AbnormalPoof AbnormalPoof AbnormalPoof approved these changes

@moxie-coder moxie-coder moxie-coder approved these changes

@JVNpixels JVNpixels JVNpixels approved these changes

@Hundrec Hundrec Hundrec approved these changes

Assignees

@EliteMasterEric EliteMasterEric

Labels
chart editor Issue is related to the operation of the Chart Editor. medium A medium pull request with 100 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Chart Editor Bug Report: Using the Live Input with number keys makes an infinite note hold
9 participants
@gamerbross @EliteMasterEric @NotHyper-474 @anysad @tposejank @AbnormalPoof @moxie-coder @JVNpixels @Hundrec