Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Implement danceEvery for Characters #2925

Merged
merged 2 commits into from
Sep 16, 2024
Merged

[BUGFIX] Implement danceEvery for Characters #2925

merged 2 commits into from
Sep 16, 2024

Conversation

gamerbross
Copy link
Contributor

This was in CharacterData but not really implemented

@charlesisfeline
Copy link

what about frameRate? i tested it and no worky

@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. type: minor bug Involves a minor bug or issue. and removed type: enhancement Provides an enhancement or new feature. labels Jun 29, 2024
@EliteMasterEric
Copy link
Member

68747470733a2f2f6d65646961312e74656e6f722e636f6d2f6d2f6c7a74624c4d454244733441414141432f736f6e69632d626f6f6d2d6b6e75636b6c65732e676966

I will also change danceEvery so that it uses event.step % (danceEvery * STEPS_PER_BEAT) so it works with any multiple of 0.25

@EliteMasterEric EliteMasterEric self-assigned this Jun 29, 2024
@EliteMasterEric EliteMasterEric added the status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. label Jun 29, 2024
@EliteMasterEric EliteMasterEric added the small A small pull request with 10 or fewer changes label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit f1d3ace into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/character-danceevery branch September 25, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

Assignees

@EliteMasterEric EliteMasterEric

Labels
small A small pull request with 10 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gamerbross @charlesisfeline @EliteMasterEric