Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Disable traces for release builds #2890

Closed
wants to merge 1 commit into from
Closed

[ENHANCEMENT] Disable traces for release builds #2890

wants to merge 1 commit into from

Conversation

doggogit
Copy link
Contributor

No clue why you guys aren't using this...

No clue why you guys aren't using this...
@doggogit doggogit changed the title Disable traces for release builds [ADJUSTMENT] Disable traces for release builds Jun 23, 2024
@doggogit doggogit changed the title [ADJUSTMENT] Disable traces for release builds [ENHANCEMENT] Disable traces for release builds Jun 23, 2024
@doggogit
Copy link
Contributor Author

For anyone curious, no, this does not disable traces in scripts in mod folders.

Example:
image

Copy link
Contributor

@tposejank tposejank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pull request... approved!

@lemz1
Copy link
Contributor

lemz1 commented Jun 23, 2024

they already have a branch doing this.

@doggogit
Copy link
Contributor Author

Oh, alright, closing!

@doggogit doggogit closed this Jun 23, 2024
@doggogit doggogit deleted the adjustment/no-traces-for-release-builds branch June 23, 2024 17:42
@tposejank
Copy link
Contributor

tposejank commented Jun 23, 2024 via email

@lemz1
Copy link
Contributor

lemz1 commented Jun 23, 2024

i do wonder though, why they havent merged it yet.

@doggogit
Copy link
Contributor Author

i do wonder though, why they havent merged it yet.

They'll do it at some point, it's fine, I didn't know about that branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants