Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT/BUGFIX] Few animation editor bugfixes and improvements #2820

Merged

Conversation

gamerbross
Copy link
Contributor

I know this editor isn't finished, but would be great to have this fixes meanwhile.

List of changes

  • The background now is a FlxBackdrop and it's scroll factors are set to 1, so it's not confusing between moving the character and moving the camera.
  • Changed flixel-ui commit to latest one so the FlxUIDropDownMenu is fixed and works properly
  • Changed the mouse behaviour a little bit so now clicking the animation dropdown doesn't move the camera and it just changes the click behaviour on click, so if you click the character and drag while passing through a ui element, it keeps dragging the character until you unclick. (just feels more comfortable)

@EliteMasterEric
Copy link
Member

  • Changed flixel-ui commit to latest one so the FlxUIDropDownMenu is fixed and works properly

I was investigating earlier and apparently this menu is the ONLY place in the game that uses flixel-ui instead of haxeui (the other places are unused imports). I'd like to remove that dropdown entirely at some point (replacing it with a dropdown in offset-editor-view.xml), but it's currently non-trivial to do that so I haven't bothered.

@EliteMasterEric EliteMasterEric self-assigned this Jun 16, 2024
@EliteMasterEric EliteMasterEric added reviewing-internally status: pending triage The bug or PR has not been reviewed yet. status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Provides an enhancement or new feature. and removed reviewing-internally status: pending triage The bug or PR has not been reviewed yet. labels Jun 16, 2024
@EliteMasterEric EliteMasterEric removed their assignment Jun 17, 2024
@gamerbross
Copy link
Contributor Author

it always shows up for me

@EliteMasterEric EliteMasterEric self-assigned this Jul 10, 2024
@EliteMasterEric EliteMasterEric added status: reviewing internally This PR is under internal review and quality assurance testing and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Jul 10, 2024
@EliteMasterEric
Copy link
Member

I will review and approve this if it's good, but my point was that the dropdown should be part of the dialog on the left rather than floating in space.

@EliteMasterEric EliteMasterEric added the medium A medium pull request with 100 or fewer changes label Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally This PR is under internal review and quality assurance testing labels Jul 12, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 12, 2024
@EliteMasterEric EliteMasterEric merged commit ebfce9f into FunkinCrew:develop Sep 16, 2024
@gamerbross gamerbross deleted the bugfix/animation-editor branch September 25, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium A medium pull request with 100 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants