Use preview Timings for FreePlay Song Preview #2729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pr makes previewTimings not useless and makes preview louder, I can’t hear a damn thing.
PurSnake
changed the title
|
FlxPartialSound doesn't get audio based off millisecond/second timing, but rather it gets the audio based on bytes and byte positions. the 0.05 start and 0.25 end refer to getting all the bytes between 5% into the song, and 25% into the song. Getting the actual second based time from a slice of bytes is a bit more complicated than just using these values, since we parse the MP3 + OGG "frames" directly, which both could have varying bitrates or sample rates that you'd have to figure out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr makes previewTimings not useless
and makes preview louder, I can’t hear a damn thing.