fix: migrate community pool spend

[zakir-code]

Summary by CodeRabbit

• New Features

  • Enhanced upgrade testing capabilities to better simulate mainnet scenarios.
  • Introduced functionality for migrating community pool spend proposals, improving governance proposal management.

• Bug Fixes

  • Refined governance proposal handling logic to ensure accurate testing outcomes.

• Refactor

  • Improved context management logic during tests for greater flexibility.

• Documentation

  • Added new helper functions for clarity in governance interactions and proposal checks.

[coderabbitai]

Walkthrough

The recent updates enhance the upgrade functionality across the Cosmos SDK application, shifting from testnet to mainnet contexts and improving governance proposal handling. Key additions include refined context management, new helper functions for governance voting, and the introduction of community pool proposal migrations. These changes aim to bolster the application's robustness and provide a more flexible, modular approach to upgrades and governance interactions.

Changes

Files	Change Summary
app/upgrade_test.go	Adjusted chainId for mainnet testing; updated newContext to include deliveState; added logic for governance proposal handling with new helper functions.
app/upgrades/v7/upgrade.go	Replaced hardcoded chain ID checks with dynamic context checks; added MigrateCommunityPoolSpendProposals and ConvertCommunityPoolSpendProposal functions.

Poem

🐰 In the garden where upgrades bloom,
New paths we carve, we make some room.
With governance whispers, and contexts anew,
A hop, a skip, to the mainnet we flew!
Upgrades and proposals, all in delight,
Let’s toast to the changes, shining so bright! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 95179d8 and 5d61d31.

Files selected for processing (2)

• app/upgrade_test.go (5 hunks)
• app/upgrades/v7/upgrade.go (3 hunks)

Additional comments not posted (8)

app/upgrades/v7/upgrade.go (3)

77-90: LGTM!

The MigrateCommunityPoolSpendProposals function is correctly implemented to migrate both inactive and active proposals.

---

92-132: LGTM!

The ConvertCommunityPoolSpendProposal function effectively converts legacy proposals to the new format, ensuring proper handling of community pool spend messages.

---

Line range hint 25-52:
Verify the integration of MigrateCommunityPoolSpendProposals.

The integration of MigrateCommunityPoolSpendProposals within the upgrade handler looks correct. Ensure that this function is adequately tested and that its behavior is as expected during the upgrade process.

app/upgrade_test.go (5)

Line range hint 35-84:
LGTM!

The Test_UpgradeAndMigrate function is well-structured and effectively tests the upgrade and migration process under mainnet conditions.

---

Line range hint 87-106:
LGTM!

The newContext function's update to include the deliveState parameter enhances flexibility in context management during tests.

---

108-144: LGTM!

The govDepositAndVote function is thorough in managing deposits and votes for governance proposals, contributing to robust test coverage.

---

146-167: LGTM!

The isUpgradeProposal function accurately identifies upgrade proposals, enhancing the clarity of proposal handling logic.

---

169-175: LGTM!

The checkProposalPassed function effectively verifies the status of proposals, ensuring that test expectations are met.