Close stale TCP connections after 10 minutes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work, since firmware have keep-alive function sending a message every 1 minute.
|
I looked at this, and it makes sense. Let's pull it in and see how it helps. Thanks! -Thom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a timeout for the inactive TCP connections. The timeout is 10 minutes, which should be fine, since firmware sends a keep-alive packet every 1 minute:
https://github.com/FujiNetWIFI/fujinet-firmware/blob/fb9e6cc7334225031a57e293309d8612a21cc74b/lib/FileSystem/fnFsTNFS.cpp#L128-L129
Also, it reduces the session timeout (affecting TCP and UDP clients) from 6 hours to 10 minutes (since the keep-alive should refresh sessions as well, regardless of the protocol).