feat: Use poetry everywhere #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update ansible to use poetry - Do not generate requirements.txt files from poetry - Upgrade poetry version to 1.3.1
|
The changes looks good to me. However, I was thinking to keep vagrant (and possibly update it with the latest Ubuntu version on AWS). My rationale on keeping it is that it helps in testing ansible deployments and any changes that are done there. Otherwise, they'll have to be tested on a dev/qa server. Please let me know what you think. |
|
I was more worried about its maintainability of it. But a agree that it's useful. If it can be updated to match with the supported version it will be worth not removing it. |
theskumar
changed the title
theskumar
force-pushed
the
upgrade-poetry
branch
from
7a397d8
to
6b76f99
Compare
|
Updated code so it doesn't touch on vagrant or VM setup |
|
Looks good to me. |
skhaz
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project gereates requirements.txt for legacy reasons
which didn't require poetry to be installed on the CI, heroku
or other places.
Installing poetry is cheap and infact used in the docker and github
actions already. This PR installs poetry during setup with ansible and
heroku as well. Eliminating the need for keeping requirements.txt in the
source control. poetry.lock is used instead for installation via poetry cli.
Poetry becomes a hard dependency for installing and managing
python dependencies everywhere.
closes: #476