Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed function as_u64 to try_as_u64 #6970

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anushkasomani
Copy link

This PR addresses Issue #6954 by renaming the as_u64 method in U128 to try_as_u64 to maintain consistency with other downcasting methods. The original as_u64 method has been deprecated with a warning to guide users toward the new naming convention.

@anushkasomani anushkasomani requested review from a team as code owners February 28, 2025 15:41
@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Feb 28, 2025

Thanks for the contribution! Before we can merge this, we need @anushkasomani to sign the Fuel Labs Contributor License Agreement.

Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for the new method.

@anushkasomani
Copy link
Author

Please add a test for the new method.

file directory?

@anushkasomani
Copy link
Author

Please add a test for the new method.

file directory?

test/src/in_language_tests/test_programs/u128_inline_tests/src/main.sw right?

@IGI-111
Copy link
Contributor

IGI-111 commented Mar 3, 2025

I believe so, yes.

@sdankel sdankel temporarily deployed to fuel-sway-bot March 4, 2025 07:41 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants