Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove root_type_id from TypeInfo::Custom. #6676

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Oct 26, 2024

Description

This PR removes root_type_id from TypeInfo::Custom.

This was used for resolving Self in associated types, but it's not needed, we can resolve those using the regular self_type we pass to name resolution.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this Oct 26, 2024
Copy link

codspeed-hq bot commented Oct 26, 2024

CodSpeed Performance Report

Merging #6676 will not alter performance

Comparing tritao:associated-types-unify (edeed2c) with master (4efd248)

Summary

✅ 22 untouched benchmarks

@tritao tritao marked this pull request as ready for review October 28, 2024 11:12
@tritao tritao requested review from a team as code owners October 28, 2024 11:12
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to merge delta negative PRs! 👍

@JoshuaBatty JoshuaBatty merged commit 759bb9e into FuelLabs:master Oct 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants