Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.sw #6546

Closed
wants to merge 1 commit into from
Closed

Update main.sw #6546

wants to merge 1 commit into from

Conversation

belamirkorkmaz
Copy link

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@belamirkorkmaz belamirkorkmaz requested review from a team as code owners September 14, 2024 20:46
@CLAassistant
Copy link

CLAassistant commented Sep 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kayagokalp kayagokalp closed this Sep 15, 2024
@kayagokalp kayagokalp reopened this Sep 15, 2024
@kayagokalp
Copy link
Member

Hey @belamirkorkmaz, thanks for the contribution. Can we get a better name and description for the PR?

kayagokalp
kayagokalp requested changes Sep 15, 2024
View reviewed changes
examples/liquidity_pool/src/main.sw
@@ -1,5 +1,3 @@
contract;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep this one in place.

@kayagokalp kayagokalp added code quality dev-experience Anything to do with the developer experience labels Sep 15, 2024
kayagokalp
kayagokalp reviewed Sep 15, 2024
View reviewed changes
examples/liquidity_pool/src/main.sw
let asset_id = AssetId::default();
assert(msg_asset_id() == asset_id);
assert(msg_amount() > 0);
assert(msg_asset_id() == BASE_ASSET, "Invalid asset ID for withdrawal");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert does not take multiple params.

@kayagokalp
Copy link
Member

Considering that this is probably an AI generated spam pr, closing it.

@kayagokalp kayagokalp closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp requested changes

Assignees

@belamirkorkmaz belamirkorkmaz

Labels
code quality dev-experience Anything to do with the developer experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@belamirkorkmaz @CLAassistant @kayagokalp