-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cargo-nextest with retries for flaky LSP test #6521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6521 will degrade performances by 17.77%Comparing Summary
Benchmarks breakdown
|
alfiedotwtf
previously approved these changes
Sep 10, 2024
sdankel
previously approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! If this works out, we could try it for #6509 as well.
Voxelot
reviewed
Sep 10, 2024
…up cargo-nextest.
JoshuaBatty
dismissed stale reviews from sdankel and alfiedotwtf
via
September 10, 2024 23:27
3f92272
…e and retries settings.
sdankel
reviewed
Sep 11, 2024
JoshuaBatty
force-pushed
the
josh/cargo-nextest
branch
from
September 11, 2024 00:51
49d2857
to
a7d9fa0
Compare
JoshuaBatty
requested review from
Voxelot,
sdankel,
alfiedotwtf and
kayagokalp
September 11, 2024 01:15
kayagokalp
approved these changes
Sep 11, 2024
IGI-111
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
cargo-nextest
to improve our test runs. We've configured 2 retries for the go_to_definition_for_paths test, which has been intermittently failing. The LSP CI workflow has been updated to usecargo-nextest
.Should mitigate #6029 until we get to the root cause why these tests are flaky.
Checklist
Breaking*
orNew Feature
labels where relevant.