Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add build script to test templates #6510

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Sep 6, 2024

Description

Closes #3026

Adds a build script to the test templates that runs prior to the tests when cargo test is run. This makes it so users who copy this template don't have to run forc build prior to cargo test

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review September 6, 2024 21:29
@sdankel sdankel requested a review from a team as a code owner September 6, 2024 21:29
@sdankel sdankel requested review from a team as code owners September 6, 2024 21:36
Copy link
Member

@K1-R1 K1-R1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition, just a few nits

templates/sway-predicate-test-rs/template/build.rs Outdated Show resolved Hide resolved
templates/sway-script-test-rs/template/build.rs Outdated Show resolved Hide resolved
templates/sway-test-rs/template/build.rs Outdated Show resolved Hide resolved
Co-authored-by: K1-R1 <77465250+K1-R1@users.noreply.github.com>
@sdankel sdankel requested a review from K1-R1 September 6, 2024 22:52
@sdankel sdankel enabled auto-merge (squash) September 9, 2024 18:26
@sdankel sdankel merged commit 507870a into master Sep 9, 2024
41 checks passed
@sdankel sdankel deleted the sophie/template-build-script branch September 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forc test used to implicitly forc build a project before running tests, whereas cargo test alone does not
4 participants