Merge master into kayagokalp/deploy-default-proxy #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Improves the UX for forc-deploy in the following ways: - uses `dialoguer` for a nicer interface for entering password, selecting the wallet account from the list, and agreeing to sign. - displays the account information in a single line, with the ETH value shown rather than the raw gwei, similar to the browser wallet - only shows the base asset amount for accounts, rather than all assets, since only base asset can be used for gas fees. - for multiple-contract deployments, users now only have to choose the account and confirm once - added error handling for the case where multi-contract deployments have different networks specified in their manifests - Displays the network URL *before* deployment rather than after - After deployment, links to the contract and block in the block explorer rather than just showing the ID ### Single contract deployed  ### Multiple contracts deployed (workspace)  ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Benchmark for b7044e8Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging in master, specifically the merge conflicts from #6278
Checklist
Breaking*orNew Featurelabels where relevant.