Make module name mandatory and private #6271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-namespace-module
Benchmark for a00f7e5Click to view benchmark
|
Benchmark for 1cb266bClick to view benchmark
|
JoshuaBatty
reviewed
Jul 16, 2024
IGI-111
reviewed
Jul 17, 2024
Benchmark for c0b0c07Click to view benchmark
|
IGI-111
approved these changes
Jul 18, 2024
Benchmark for 7dd3dcbClick to view benchmark
|
tritao
approved these changes
Jul 18, 2024
Benchmark for ef00e28Click to view benchmark
|
JoshuaBatty
approved these changes
Jul 19, 2024
esdrubal
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Description Partial fix of #5498 . So far the `name` field in `namespace::Module` has been public and of type `Option<Ident>`. This makes little sense, since the name of a module should always have a value, and should retain that value once it is set. This PR fixes this problem. The `visibility` and `span` fields have also been made private. `visibility` can be read-only, but there is a single instance in which the `span` field must be set later, so I have added a setter for that field too. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. --------- Co-authored-by: IGI-111 <igi-111@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix of #5498 .
So far the
namefield innamespace::Modulehas been public and of typeOption<Ident>. This makes little sense, since the name of a module should always have a value, and should retain that value once it is set. This PR fixes this problem.The
visibilityandspanfields have also been made private.visibilitycan be read-only, but there is a single instance in which thespanfield must be set later, so I have added a setter for that field too.Checklist
Breaking*orNew Featurelabels where relevant.