Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in comment for ipfs fetching in forc-pkg #6236

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

kayagokalp
Copy link
Member

Description

Curretnly CI is broken as spellcheck is finding a new error it used to not found. This pr fixes it to get CI passing again.

@kayagokalp kayagokalp added bug Something isn't working ci labels Jul 5, 2024
@kayagokalp kayagokalp self-assigned this Jul 5, 2024
@kayagokalp kayagokalp marked this pull request as ready for review July 5, 2024 18:45
@kayagokalp kayagokalp requested a review from a team as a code owner July 5, 2024 18:45
@kayagokalp kayagokalp enabled auto-merge (squash) July 5, 2024 18:46
@kayagokalp kayagokalp requested review from a team July 5, 2024 18:47
Copy link

github-actions bot commented Jul 5, 2024

Benchmark for 15a3a02

Click to view benchmark
Test Base PR %
code_action 5.2±0.32ms 5.6±0.42ms +7.69%
code_lens 278.9±9.05ns 289.8±10.62ns +3.91%
compile 2.7±0.06s 2.6±0.10s -3.70%
completion 5.0±0.61ms 4.9±0.50ms -2.00%
did_change_with_caching 2.6±0.05s 2.6±0.07s 0.00%
document_symbol 849.3±16.45µs 895.9±33.54µs +5.49%
format 72.0±1.08ms 71.6±1.35ms -0.56%
goto_definition 343.7±25.10µs 341.6±10.08µs -0.61%
highlight 9.1±0.36ms 9.2±0.37ms +1.10%
hover 503.8±23.58µs 497.5±12.99µs -1.25%
idents_at_position 121.2±2.88µs 119.3±0.71µs -1.57%
inlay_hints 649.7±28.12µs 646.6±21.46µs -0.48%
on_enter 475.8±34.79ns 470.9±12.82ns -1.03%
parent_decl_at_position 3.8±0.11ms 3.7±0.06ms -2.63%
prepare_rename 347.3±34.55µs 340.5±10.87µs -1.96%
rename 9.5±0.34ms 9.7±0.29ms +2.11%
semantic_tokens 1284.4±134.78µs 1206.4±33.61µs -6.07%
token_at_position 341.2±5.06µs 355.1±15.60µs +4.07%
tokens_at_position 3.8±0.20ms 3.7±0.11ms -2.63%
tokens_for_file 405.8±4.89µs 406.6±8.88µs +0.20%
traverse 37.9±0.52ms 38.3±0.67ms +1.06%

@kayagokalp kayagokalp requested a review from a team July 5, 2024 21:40
@kayagokalp kayagokalp merged commit f81b6c2 into master Jul 5, 2024
36 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/spellcheck-fix branch July 5, 2024 22:24
Copy link

github-actions bot commented Jul 5, 2024

Benchmark for 73aa92f

Click to view benchmark
Test Base PR %
code_action 5.1±0.08ms 5.1±0.08ms 0.00%
code_lens 288.4±12.17ns 288.9±8.98ns +0.17%
compile 2.6±0.02s 2.6±0.04s 0.00%
completion 4.6±0.06ms 4.6±0.10ms 0.00%
did_change_with_caching 2.5±0.06s 2.5±0.04s 0.00%
document_symbol 953.9±38.59µs 923.8±22.44µs -3.16%
format 72.0±0.96ms 72.1±1.07ms +0.14%
goto_definition 342.7±7.77µs 339.4±6.65µs -0.96%
highlight 8.7±0.12ms 8.7±0.16ms 0.00%
hover 499.3±6.75µs 494.2±5.82µs -1.02%
idents_at_position 117.2±0.71µs 118.8±0.35µs +1.37%
inlay_hints 628.7±22.48µs 631.3±37.05µs +0.41%
on_enter 466.1±17.40ns 461.2±33.52ns -1.05%
parent_decl_at_position 3.6±0.04ms 3.6±0.13ms 0.00%
prepare_rename 352.9±6.14µs 340.2±7.95µs -3.60%
rename 9.0±0.14ms 9.0±0.12ms 0.00%
semantic_tokens 1242.0±10.79µs 1261.5±19.34µs +1.57%
token_at_position 334.3±3.31µs 340.3±2.52µs +1.79%
tokens_at_position 3.6±0.05ms 3.6±0.04ms 0.00%
tokens_for_file 393.5±4.12µs 402.4±2.05µs +2.26%
traverse 38.2±0.52ms 37.7±0.73ms -1.31%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants