Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From<u8, u16, u32> for u64 implementations #5817

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Conversation

SwayStar123
Copy link
Member

@SwayStar123 SwayStar123 commented Apr 2, 2024

Description

Adds implementations for From, From, From for u64

Partially addresses #5797

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Apr 2, 2024
@SwayStar123 SwayStar123 self-assigned this Apr 2, 2024
@IGI-111
Copy link
Contributor

IGI-111 commented Apr 2, 2024

N.B.: don't use "partially closes X" in issue descriptions, Github isn't smart enough to figure out the "partially" and will enable the autoclose.

If you just want it to be linked, use different vocabulary, such as "partially addresses".

@SwayStar123
Copy link
Member Author

N.B.: don't use "partially closes X" in issue descriptions, Github isn't smart enough to figure out the "partially" and will enable the autoclose.

If you just want it to be linked, use different vocabulary, such as "partially addresses".

Thanks for the tip!

@SwayStar123 SwayStar123 enabled auto-merge (squash) April 3, 2024 05:01
@SwayStar123 SwayStar123 merged commit 35df2a7 into master Apr 3, 2024
33 checks passed
@SwayStar123 SwayStar123 deleted the u64-implementations branch April 3, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants