Disable DCA and writing diagnostics on did_change events #5555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBatty
added
language server
JoshuaBatty
force-pushed
the
josh/optimized_build
branch
from
e3f9229
to
87f5931
Compare
JoshuaBatty
force-pushed
the
josh/optimized_build
branch
from
2f8a3c9
to
c564675
Compare
12 tasks
tritao
reviewed
Feb 6, 2024
tritao
approved these changes
Feb 6, 2024
sdankel
approved these changes
Feb 6, 2024
sdankel
pushed a commit
that referenced
this pull request
Feb 8, 2024
## Description This PR does 3 optimizations. The timings below are measured against the LSP benchmarking project. 1. Disable running DCA & control flow analysis, for did_change events `39.544ms` 2. Disable running collect_types_metadata for did_change events `3.522ms` 3. Only write the diagnostics res to self.diagnostics.write() on did_open & did_save `21.135ms` I also had to increase the frequency that we are calling GC to every 3rd keystroke as during stress tests I was occasionally getting stack overflows otherwise. related to #5445 ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [ ] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does 3 optimizations. The timings below are measured against the LSP benchmarking project.
39.544ms3.522ms21.135msI also had to increase the frequency that we are calling GC to every 3rd keystroke as during stress tests I was occasionally getting stack overflows otherwise.
related to #5445
Checklist
Breaking*orNew Featurelabels where relevant.