Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parser panics in edge cases #5155

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix parser panics in edge cases #5155

merged 2 commits into from
Oct 2, 2023

Conversation

IGI-111
Copy link
Contributor

@IGI-111 IGI-111 commented Sep 29, 2023 •
edited
Loading

Description

Will partially address #5049

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@IGI-111 IGI-111 added bug Something isn't working compiler: parser Everything to do with the parser labels Sep 29, 2023
@IGI-111 IGI-111 requested a review from a team September 29, 2023 17:06
@IGI-111 IGI-111 self-assigned this Sep 29, 2023
ironcev
ironcev previously approved these changes Sep 30, 2023
View reviewed changes
@ironcev
Copy link
Member

ironcev commented Sep 30, 2023

The changes fix parser panics but not the overflow issue, the parse_overflow test is failing. Will this be a separate PR?

@IGI-111 IGI-111 marked this pull request as draft October 2, 2023 03:38
@IGI-111
Copy link
Contributor Author

IGI-111 commented Oct 2, 2023

Still fixing that one, should have made this a draft.

@IGI-111
Fix parser panics in edge cases
8c1d485 
Will partially address #5049
@IGI-111
Copy link
Contributor Author

IGI-111 commented Oct 2, 2023

On second thought, let's make this a separate PR.

@IGI-111 IGI-111 marked this pull request as ready for review October 2, 2023 19:57
@IGI-111 IGI-111 requested review from ironcev and a team October 2, 2023 19:57
@IGI-111 IGI-111 enabled auto-merge (squash) October 2, 2023 19:57
@IGI-111 IGI-111 merged commit 91046eb into master Oct 2, 2023
32 checks passed
@IGI-111 IGI-111 deleted the IGI-111/parser-panics branch October 2, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaBatty JoshuaBatty JoshuaBatty approved these changes

@ironcev ironcev ironcev approved these changes

Assignees

@IGI-111 IGI-111

Labels
bug Something isn't working compiler: parser Everything to do with the parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IGI-111 @ironcev @JoshuaBatty