Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] forc-client techincal debts #6259

Open
kayagokalp opened this issue Jul 11, 2024 · 0 comments
Open

[Tracking] forc-client techincal debts #6259

kayagokalp opened this issue Jul 11, 2024 · 0 comments
Labels
code quality forc forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy

Comments

@kayagokalp
Copy link
Member

kayagokalp commented Jul 11, 2024

forc-client is a very vibrant section of our codebase, and a lot of changes land there regularly, and it is getting expanded as the time pass. I think it is time for us to have a nice cleaning done, so that we have stronger foundations in place.

  1. Let's try to de-duplicate efforst between sdk and forc-client as much as possible, now that sdk has a estimation flow in place we can remove our code and use theirs
  2. Folder/file structure can be improved a little: forc-client is expanding all the time and some files can be split or could use same new names.
  3. As part of feat: create and deploy a reference proxy contract for contracts with [proxy] enabled #6069 we have a nice improvement in testability of the crate, we should continue this effort and extend our test suite.
  4. We should start following the code coverage for forc-client.
  5. We can use indoc for most of the places we are embedding src code for better readability
  6. https://github.com/FuelLabs/sway/pull/6250/files/11333a39d9e39f13ba77c6db577e40982c479a9e#r1712381927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality forc forc-client Everything related to the `forc-client` crate. forc-deploy Everything to do with forc-deploy
Projects
None yet
Development

No branches or pull requests

1 participant