Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable LSP tests and pin std to latest release #6258

Closed
JoshuaBatty opened this issue Jul 10, 2024 · 0 comments · Fixed by #6315
Closed

Reenable LSP tests and pin std to latest release #6258

JoshuaBatty opened this issue Jul 10, 2024 · 0 comments · Fixed by #6315
Assignees
Labels

Comments

@JoshuaBatty
Copy link
Member

Some tests were commented out in #6256 as we need to wait for #6116 to land first.

We should also remove referencing std like this std = { path = "../../../../../sway-lib-std" } and instead pin back to a recent release like we were previously doing .. std = { git = "https://github.com/FuelLabs/sway", tag = "v0.62.0" }

@JoshuaBatty JoshuaBatty self-assigned this Jul 10, 2024
@JoshuaBatty JoshuaBatty added the language server LSP server label Jul 10, 2024
esdrubal pushed a commit that referenced this issue Aug 13, 2024
…d out tests (#6315)

## Description
closes #4211
closes #6258

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant