Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all deps to be the latest version across the whole repo #6179

Open
JoshuaBatty opened this issue Jun 24, 2024 · 0 comments · May be fixed by #6190
Open

Update all deps to be the latest version across the whole repo #6179

JoshuaBatty opened this issue Jun 24, 2024 · 0 comments · May be fixed by #6190
Assignees
@alfiedotwtf
Labels
code quality

Comments

@JoshuaBatty
Copy link
Member

JoshuaBatty commented Jun 24, 2024 •
edited by rvcas
Loading

Also, it might be worth us migrating to defining dependencies used across multiple workspace members in a [workspace.dependencies] section. Eg

[workspace.dependencies]
clap = "4.5"
dashmap = "6.0"

Then in the member projections Cargo.toml we can bring them in like

[dependencies]
clap = { workspace = true }
dashmap = { workspace = true }
@rvcas rvcas linked a pull request Jun 25, 2024 that will close this issue
Draft
8 tasks
@JoshuaBatty JoshuaBatty assigned alfiedotwtf and unassigned rvcas Aug 16, 2024
alfiedotwtf added a commit that referenced this issue Sep 5, 2024
@alfiedotwtf
Add the workspace version to the root Cargo.toml (#6179)
8f3e608
@alfiedotwtf alfiedotwtf mentioned this issue Sep 5, 2024
Open
alfiedotwtf added a commit that referenced this issue Sep 5, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
33810ae 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Add the workspace version to the root Cargo.toml (#6179)
d4d5c44
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
62d047f 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Bump workspace to v0.63.4 (#6179)
7376b1e
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Move all external dependencies to the workspace (#6179)
df80209
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Clean up single attributed dependencies (#6179)
c1d2db3
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Fix Cargo dependency sort order (#6179)
bf22cfa
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Revert non-workspace Cargo.toml (#6179)
ba0e9d3
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Fix Cargo dependency sort order (#6179)
1a2a440
alfiedotwtf added a commit that referenced this issue Sep 6, 2024
@alfiedotwtf
Revert non-workspace Cargo.toml (#6179)
ff3c935
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Add the workspace version to the root Cargo.toml (#6179)
64588a3
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
6eefe2e 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Bump workspace to v0.63.4 (#6179)
a3f8ded
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Move all external dependencies to the workspace (#6179)
6ff4130
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Clean up single attributed dependencies (#6179)
f3c3a5f
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Fix Cargo dependency sort order (#6179)
75ae8f6
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Revert non-workspace Cargo.toml (#6179)
6ba80ff
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Dependency features removed from the workspace Cargo.toml (#6179)
713d02f
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
More single attributed dependency cleanup (#6179)
18d2083
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Bump workspace to v0.63.5 (#6179)
cb684bf
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo deps with build-in cargo tree (#6179)
49b6641 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
@alfiedotwtf alfiedotwtf mentioned this issue Sep 9, 2024
Merged
8 tasks
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo-deps with build-in cargo tree (#6179)
82df7f1 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Replace cargo-deps with built-in cargo tree (#6179)
a41b9b0 
- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces
alfiedotwtf added a commit that referenced this issue Sep 9, 2024
@alfiedotwtf
Version bumps in test harness: fuel-core(v0.35.0), fuel-core-client(v…
87de96e 
…0.35.0), fuels(v0.66.4) (#6179)
alfiedotwtf added a commit that referenced this issue Sep 10, 2024
@alfiedotwtf
Remove default-features as they are inherited from the workspace Ca…
e75280e 
…rgo.toml (#6179)
alfiedotwtf added a commit that referenced this issue Sep 10, 2024
@alfiedotwtf
Version bump for all easily upgradable dependencies and dev-dependenc…
d3dcae3 
…ies (#6179)
IGI-111 pushed a commit that referenced this issue Sep 10, 2024
@alfiedotwtf @sdankel
Replace cargo deps with built-in cargo tree (#6179) (#6515)
5699721 
Separating this commit out from the main commit of #6179...

This PR comes in two commits:

1. The changes to CI - replace `cargo-deps` with `cargo tree`
2. A test commit that will create a cyclic dependency which will be
reverted once it's tested to be working

The origin commit message:

- cargo-deps is no longer maintained
- cargo-deps doesn't understand workspaces

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [x] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

Co-authored-by: Sophie Dankel <47993817+sdankel@users.noreply.github.com>
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Move dependencies to the workspace Cargo.toml and version bump (#6179)
b3e22f5
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fixes for all the version bumps (#6179)
9791b81
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Version bump Rust to 1.81.0, and nightly to nightly-2024-09-11 (#6179)
771d4ad
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Move dependencies to the workspace Cargo.toml and version bump (#6179)
a7212ea
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fixes for all the version bumps (#6179)
8f550f3
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Version bump Rust to 1.81.0, and nightly to nightly-2024-09-11 (#6179)
0df0880
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix all version bumps issues (#6179)
8327311
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Version bump Rust to 1.81.0, and nightly to nightly-2024-09-11 (#6179)
04e6bc5
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy issues (#6179)
e038936
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy issues (#6179)
071729d
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy issues (#6179)
87f0a44
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy issues (#6179)
b4ced18
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy issues (#6179)
4ce8d65
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy issues (#6179)
9793b0b
alfiedotwtf added a commit that referenced this issue Sep 12, 2024
@alfiedotwtf
Fix clippy and CI issues (#6179)
e418472
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Move dependencies to the workspace Cargo.toml and version bump (#6179)
62532b8
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix all version bumps issues (#6179)
a9d4b9f
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Version bump Rust to 1.81.0, and nightly to nightly-2024-09-11 (#6179)
95388ea
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix clippy and CI issues (#6179)
2dc5618
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix rebase issues and support act in CI (#6179)
eb88343 
- Support `act` in ci.yml for local testing
- Add documentation for `act` testing
- Add `act` binary to .gitignore
- Version bump differences
- Test fixtures
- Minor changes for errors and typos
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix rebase issues and support act in CI (#6179)
0eaec01 
- Support `act` in ci.yml for local testing
- Add documentation for `act` testing
- Add `act` binary to .gitignore
- Version bump differences
- Test fixtures
- Minor changes for errors and typos
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix rebase issues and support act in CI (#6179)
0be34ba 
- Support `act` in ci.yml for local testing
- Add documentation for `act` testing
- Add `act` binary to .gitignore
- Version bump differences
- Test fixtures
- Minor changes for errors and typos
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix rebase issues and support act in CI (#6179)
6780e76 
- Support `act` in ci.yml for local testing
- Add documentation for `act` testing
- Add `act` binary to .gitignore
- Version bump differences
- Test fixtures
- Minor changes for errors and typos
alfiedotwtf added a commit that referenced this issue Sep 16, 2024
@alfiedotwtf
Fix rebase issues and support act in CI (#6179)
8c73032 
- Support `act` in ci.yml for local testing
- Add documentation for `act` testing
- Add `act` binary to .gitignore
- Version bump differences
- Test fixtures
- Minor changes for errors and typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfiedotwtf alfiedotwtf

Labels
code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update all the deps FuelLabs/sway
3 participants
@alfiedotwtf @JoshuaBatty @rvcas