Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the contract_id() function #5834

Closed
bitzoic opened this issue Apr 8, 2024 · 0 comments · Fixed by #5867
Closed

Deprecate the contract_id() function #5834

bitzoic opened this issue Apr 8, 2024 · 0 comments · Fixed by #5867
Assignees
@bitzoic
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library

Comments

@bitzoic
Copy link
Member

bitzoic commented Apr 8, 2024 •
edited
Loading

We currently support 2 methods of getting the contract id of a contract in an internal context:

  • contract_id()
  • ContractId::this()

The this() associated function is a constructor that returns Self and should be the primary method of getting the contract id. This idiomatically follows Rust's syntax.

The same syntax is followed with AssetId::base().
@bitzoic bitzoic added lib: std Standard library breaking May cause existing user code to break. Requires a minor or major release. labels Apr 8, 2024
@bitzoic bitzoic self-assigned this Apr 16, 2024
@bitzoic bitzoic linked a pull request Apr 17, 2024 that will close this issue
Remove contract_id() in favor of ContractId::this() #5867
Merged
8 tasks
@bitzoic bitzoic mentioned this issue Apr 17, 2024
Merged
8 tasks
bitzoic added a commit that referenced this issue Apr 18, 2024
@bitzoic @SwayStar123
Remove contract_id() in favor of ContractId::this() (#5867)
3f47df8 
## Description

We currently support 2 methods of getting the contract id of a contract
in an internal context:

- `contract_id()`
- `ContractId::this()`

The `this()` associated function is a constructor that returns `Self`
and should be the primary method of getting the contract id. This
idiomatically follows Rust's syntax and `contract_id()` has been
removed.

The same syntax is followed with `AssetId::base()`.

Closes #5834 

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: SwayStar123 <46050679+SwayStar123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitzoic bitzoic

Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove contract_id() in favor of ContractId::this() FuelLabs/sway
1 participant
@bitzoic