-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a symbol resolution step #5379
Labels
big
this task is hard and will take a while
code quality
compiler: collection
Everything to do with graph collection, type collection, and the collection context.
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Comments
IGI-111
added
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
compiler: collection
Everything to do with graph collection, type collection, and the collection context.
labels
Dec 12, 2023
This was referenced Apr 18, 2024
This will be partially fixed by #5809. |
tritao
added a commit
that referenced
this issue
Aug 6, 2024
## Description This PR implements a new AST resolution approach that resolves symbols using the information from the collection context. To achieve this, we introduce a new `ResolveSymbols` trait and `SymbolResolveContext` context type. Parsed nodes now contain a `resolved_call_path_binding: Option<TypeBinding<ResolvedCallPath<ParsedDeclId<...>>>>`, which contain the resolved call path binding that references the `ParsedDeclId` relative to the resolved name. This field is resolved by the new `resolve_symbols` pass, which mutates the `resolved_call_path_binding` as it walks through the nodes. Most of the name lookups are implemented in the new `SymbolResolveTypeBinding` which is equivalent to the existing `TypeCheckTypeBinding` (to be removed once everything is migrated in the type checker). The only exception right now are `DelineatedPath` and `AmbiguousPathExpression` which are not being fully resolved yet (though there is a draft PR right now with some of this ongoing work). Also to note there are a handful of unused functions in the context that will be used in the next PRs. These are the main commits: [Implement Declaration::TraitFn.](8da3223) [Implement decl_engine_parsed_decl and get_parsed_decl.](dd6f5e6) [Fix lexical scope id calculation on creation.](e16d996) [Add symbol resolve context.](e9356cc) [Collect nodes inside each function body and keep a reference to their lexical scope](e327345) [Resolve alias declarations when resolving struct symbols.](2c8dc64) Partially closes #5379. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
esdrubal
pushed a commit
that referenced
this issue
Aug 13, 2024
## Description This PR implements a new AST resolution approach that resolves symbols using the information from the collection context. To achieve this, we introduce a new `ResolveSymbols` trait and `SymbolResolveContext` context type. Parsed nodes now contain a `resolved_call_path_binding: Option<TypeBinding<ResolvedCallPath<ParsedDeclId<...>>>>`, which contain the resolved call path binding that references the `ParsedDeclId` relative to the resolved name. This field is resolved by the new `resolve_symbols` pass, which mutates the `resolved_call_path_binding` as it walks through the nodes. Most of the name lookups are implemented in the new `SymbolResolveTypeBinding` which is equivalent to the existing `TypeCheckTypeBinding` (to be removed once everything is migrated in the type checker). The only exception right now are `DelineatedPath` and `AmbiguousPathExpression` which are not being fully resolved yet (though there is a draft PR right now with some of this ongoing work). Also to note there are a handful of unused functions in the context that will be used in the next PRs. These are the main commits: [Implement Declaration::TraitFn.](8da3223) [Implement decl_engine_parsed_decl and get_parsed_decl.](dd6f5e6) [Fix lexical scope id calculation on creation.](e16d996) [Add symbol resolve context.](e9356cc) [Collect nodes inside each function body and keep a reference to their lexical scope](e327345) [Resolve alias declarations when resolving struct symbols.](2c8dc64) Partially closes #5379. ## Checklist - [x] I have linked to any relevant issues. - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [x] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [x] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
big
this task is hard and will take a while
code quality
compiler: collection
Everything to do with graph collection, type collection, and the collection context.
compiler: frontend
Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Refactor the way we build namespaces and type check into a separate step that resolves all the symbols to unique paths/ids before type checking.
This should help us with issues with the current approach whereby some of this is done on the fly by the namespace resolution and some of it is done by comparing type names as strings.
The idea is to have a three step process:
The text was updated successfully, but these errors were encountered: