Slow plugin

[PaulZhemanov]

Hi guys! I'm having trouble getting the plugin to work correctly. It works so slowly. I need correct autocomplete, go to definition, hinting of function signature and arguments. Help me please.

forc-lsp 0.49.3

[JoshuaBatty]

Hi Paul, I'm happy to look into this for you. Do you have a specific project I might be able to reproduce with?

[PaulZhemanov]

Hi Paul, I'm happy to look into this for you. Do you have a specific project I might be able to reproduce with?

Hi! Can you send telegram nickname?

[PaulZhemanov]

Hi Paul, I'm happy to look into this for you. Do you have a specific project I might be able to reproduce with?

Hi! Can you send telegram nickname?

@JoshuaBatty

[chlenc]

Shared the spark access 🫡
@JoshuaBatty @PaulZhemanov
https://github.com/compolabs/spark-perps/invitations

[JoshuaBatty]

Received thanks guys. I'll start doing some profiling over the next week.

[PaulZhemanov]

Received thanks guys. I'll start doing some profiling over the next week.

@JoshuaBatty this "loading" appears very often and hinders development,

[PaulZhemanov]

@JoshuaBatty Hello. The plugin is terrible.. I compile my contract with no errors and see this in my editor...

A plugin should speed up development, not slow it down. Please fix it.

[JoshuaBatty]

Hi @PaulZhemanov please know we are aware of the issue and that we are working on this as a priority. We will hopefully have a fix soon. The TLDR of the issue is the compiler is crashing due to the garbage collector not working properly for certain types. When this happens it also crashed the server plugin, leading to the screenshots. Reloading the window will allow it to work again until the next time the GC <> compiler become out of sync. Obviously this is very frustrating for users and we are looking into a fix.

[JoshuaBatty]

If you want a quick fix you could checkout my josh/storage_gc_test branch on the sway repo and change this line from true to false gc_enabled: false,

then run cargo install --path ./forc-plugins/forc-lsp to install a local copy of the language server. Because the garbage collector is disabled you'll probably want to reload the editor when the RAM usage gets too high but it should at least get rid of the crash for now while we investigate the root cause.

[JoshuaBatty]

Hey @chlenc & @PaulZhemanov we have fixed the Garbage collector and LSP issues. This has been merged and is in the latest 0.54 release. It's still going to be slow to respond due to the lack of granular caching and the size of your workspace, but it shouldn't be crashing and become non-responsive now. We're now looking at further optimisations.

[chlenc]

gm guys thank you!!

Btw is it possible to somehow disable reentrancy warnings?

[chlenc]

[chlenc]

@JoshuaBatty

[JoshuaBatty]

Sorry i've been out sick this week. We don't off the ability to disable certain warning types but we could look at adding that in the future. I'll take a closer look at this next week and see what we might be able to do.

[PaulZhemanov]

Hi @JoshuaBatty . I got this notification and plugin doesnt work.

[PaulZhemanov]

Hi @JoshuaBatty . how can I disable these settings

If you want a quick fix you could checkout my josh/storage_gc_test branch on the sway repo and change this line from true to false gc_enabled: false,

then run cargo install --path ./forc-plugins/forc-lsp to install a local copy of the language server. Because the garbage collector is disabled you'll probably want to reload the editor when the RAM usage gets too high but it should at least get rid of the crash for now while we investigate the root cause.

[JoshuaBatty]

Hi Paul what version of forc-lsp are you using?

The garbage collection issue has been resolved and is in the latest release.

[mpoplavkov]

Hey @chlenc & @PaulZhemanov we have fixed the Garbage collector and LSP issues. This has been merged and is in the latest 0.54 release. It's still going to be slow to respond due to the lack of granular caching and the size of your workspace, but it shouldn't be crashing and become non-responsive now. We're now looking at further optimisations.

Hey @JoshuaBatty, how to update forc-lsp to 0.54 if I'm using the beta-5 channel?

[PaulZhemanov]

@JoshuaBatty forc-lsp 0.49.3

[JoshuaBatty]

I would suggest the quickest way to get it working would be to checkout the sway repo and follow the below commands to get the server updated.

git checkout https://github.com/FuelLabs/sway
cd sway
cargo install --path ./forc-plugins/forc-lsp

then running the which forc-lsp you should see something like.

 ~  which forc-lsp                                                                                           
/Users/joshuabatty/.cargo/bin/forc-lsp

 ~  forc-lsp --version                                                                                  
forc-lsp 0.56.0

[chlenc]

hope plugin will be better soon

[chlenc]

Gm guys

@JoshuaBatty @arboleya

Are there any updates??

[JoshuaBatty]

The main issue here is that our compiler is slow and we lack a caching system to support more incremental compilation. We are focusing on improving compilation speeds at the moment, in-fact we have merged 3 PR's in the past 24 hours that have improved compilation speeds by ~60%. We are also in the process of putting together a design for implementing more granular caching. Unfortunately, until the compiler is optimised and caching support is implemented then the language server performance is going to be sluggish on large projects like the spark repo. I'll keep you updated as we go.

[JoshuaBatty]

Another update, we now have support for caching at the file level rather than the previous project level. This should speed up response times substantially for projects with lots of files. We have plans to enable caching at the AST node level but this should be a nice bridge in the meantime.