Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve sdks and tests #982

Merged
merged 13 commits into from
Nov 30, 2023
Merged

feat: improve sdks and tests #982

merged 13 commits into from
Nov 30, 2023

Conversation

luizstacio
Copy link
Member

@luizstacio luizstacio commented Nov 20, 2023 •
edited
Loading

On this PR;

  • Improve react package to have a single provider, avoiding the need to add two providers.
  • Adds configurations on the provider to inform Fuel SDK options and UI options.
  • Add some new hooks that help to improve the flow on most common actions.
  • Add's the assets metadata event removed on the previous version.
  • Fix the hooks watcher that was not working consistently.

closes: FE-62

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 20, 2023 •
edited
Loading

Coverage report for ./packages/app

St.❔
 Category Percentage Covered / Total
🟡 Statements 67.68% 3384/5000
🔴 Branches 44.53% 619/1390
🔴 Functions 51.25% 716/1397
🟡 Lines 68.24% 3260/4777

Test suite run success

241 tests passing in 73 suites.

Report generated by 🧪jest coverage report action from a651bbe

@linear Linear
Copy link

linear bot commented Nov 20, 2023

FE-62 Improve Fuel Wallet SDK V2

@luizstacio luizstacio marked this pull request as ready for review November 21, 2023 00:53
LuizAsFight
LuizAsFight requested changes Nov 21, 2023
View reviewed changes
packages/app/src/systems/Send/machines/sendMachine.ts Outdated Show resolved Hide resolved
packages/react/src/components/index.tsx Outdated Show resolved Hide resolved
packages/react/src/hooks/useWallet.tsx Show resolved Hide resolved
packages/react/src/providers/FuelEventsWatcher.tsx Outdated Show resolved Hide resolved
packages/react/src/providers/FuelEventsWatcher.tsx Outdated Show resolved Hide resolved
packages/react/src/providers/FuelProvider.tsx Show resolved Hide resolved
packages/sdk/src/Fuel.ts Show resolved Hide resolved
packages/sdk/src/tests/FuelWallet.test.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2023 •
edited
Loading

This PR is published in NPM with version 0.14.0-preview-a651bbe

@luizstacio @LuizAsFight
Update packages/app/src/systems/Send/machines/sendMachine.ts
285f795 
Co-authored-by: Luiz Gomes - LuizAsFight.eth <8636507+LuizAsFight@users.noreply.github.com>
LuizAsFight
LuizAsFight approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work

@luizstacio luizstacio merged commit 53eb70c into sdk-v2 Nov 30, 2023
11 checks passed
@luizstacio luizstacio deleted the ls/feat/improvements-sdk branch November 30, 2023 02:54
luizstacio added a commit that referenced this pull request Jan 11, 2024
@luizstacio
feat: improve sdks and tests (#982)
1f7767f
@luizstacio luizstacio mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@pedronauck pedronauck Awaiting requested review from pedronauck

@matt-user matt-user Awaiting requested review from matt-user

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizstacio @LuizAsFight