Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release workflow permissions and remove npm setup #1831

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

nelitow
Copy link
Contributor

@nelitow nelitow commented Feb 11, 2025

Summary

These changes are meant so that the create-pr action doesnt use the npm-deployenvironment, therefore not needing the action permission to run, while keeping the permission requirement for the NPM dpeloy action.

Checklist

  • I've added error handling for all actions/requests, and verified how this error will show on UI. (or there was no error handling)
  • I've reviewed all the copy changed/added in this PR, using AI if needed. (or there was no copy changes)
  • I've included the reference to the issues being closed from Github and/or Linear (or there was no issues)
  • I've changed the Docs to reflect my changes (or it was not needed)
  • I've put docs links where it may be helpful (or it was not needed)
  • I checked the resulting UI both in Light and Dark mode (or no UI changes were made)
  • I reviewed the entire PR myself (preferably, on GH UI)

@LuizAsFight LuizAsFight merged commit f07b043 into master Feb 11, 2025
26 of 27 checks passed
@LuizAsFight LuizAsFight deleted the nj/fix/pr-flow-auth branch February 11, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants