fix: infinite loading on too many requests #1809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurgeron
requested review from
luizstacio,
LuizAsFight,
helciofranco,
rodrigobranas and
nelitow
as code owners
Voxelot
reviewed
Feb 5, 2025
| const result = await TxService.getAllCursors({ | ||
| address, | ||
| providerUrl, | ||
| initialEndCursor, | ||
| maxDepth: 1, |
There was a problem hiding this comment.
Does this still allow for scrolling through all transactions? Or will it limit the results to the first page?
There was a problem hiding this comment.
It passes the last cursor position so it won't fetch the same data everytime, only the data that needs to be shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Infinite Loading on TX History #1808
Closes FE-1433
Fixed infinitely reading all transactions, now instead it only loads the data for what it's going to show (i.e. current page)
Also transaction History screen should now load faster, including data incoming after clicking on "load more"
CleanShot.2025-02-05.at.15.57.34.mp4