Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add NFTs tab #1762

Merged
merged 22 commits into from
Jan 17, 2025
Merged

feat: add NFTs tab #1762

merged 22 commits into from
Jan 17, 2025

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Jan 9, 2025 •
edited
Loading

📷 Demo
Screen.Recording.2025-01-15.at.18.06.57.mov

@helciofranco helciofranco self-assigned this Jan 9, 2025
@helciofranco helciofranco linked an issue Jan 9, 2025 that may be closed by this pull request
Create NFT tab for balances in Home Screen #1686
Closed
@helciofranco helciofranco marked this pull request as ready for review January 9, 2025 09:14
@helciofranco helciofranco enabled auto-merge (squash) January 9, 2025 09:15
LuizAsFight
LuizAsFight requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we start with all collections expanded? except by the "Others" , that one can be collapsed

LuizAsFight
LuizAsFight requested changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • in the black theme I can't see any separator between the collections
  • I think the collection name can be a little bit bigger (in your video it looks bigger than when I run locally), did you change it after recording?

@helciofranco
Copy link
Member Author

@LuizAsFight

  • in the black theme I can't see any separator between the collections
  • I think the collection name can be a little bit bigger (in your video it looks bigger than when I run locally), did you change it after recording?
    • Nope. The video you've seen was the version you reviewed.. I think it's because it has a natural "scale" in the preview. I'll increase a little bit (from $sm to $base). 76ba41b

arthurgeron
arthurgeron requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@arthurgeron arthurgeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When I expand the top Collapsible there's some extra empty space that pushes that seems to overlap with other sections.
    CleanShot 2025-01-13 at 13 49 47
    CleanShot 2025-01-13 at 13 50 42

  • When expanded there is also a separator that seems to be duplicated:
    CleanShot 2025-01-13 at 13 51 09

@helciofranco helciofranco marked this pull request as draft January 13, 2025 19:17
auto-merge was automatically disabled January 13, 2025 19:17

Pull request was converted to draft

@helciofranco helciofranco marked this pull request as ready for review January 14, 2025 08:20
@helciofranco helciofranco enabled auto-merge (squash) January 14, 2025 16:56
arthurgeron
arthurgeron previously approved these changes Jan 14, 2025
View reviewed changes
LuizAsFight
LuizAsFight requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figma: image
current: image

  • smaller arrow
  • "number" in collection should have a min-width to always be square at minimun
  • put copy button on assetId from "Others" collection

@helciofranco helciofranco merged commit 2460bee into master Jan 17, 2025
31 of 32 checks passed
@helciofranco helciofranco deleted the hf/feat/nft-tabs branch January 17, 2025 21:54
@fuel-service-user fuel-service-user mentioned this pull request Jan 17, 2025
Merged
arthurgeron pushed a commit that referenced this pull request Jan 18, 2025
@helciofranco @arthurgeron
feat: add NFTs tab (#1762)
bd3626f 
- Closes #1686 
- Closes `FE-1087`

---


| 📷 Demo |
| --- |
| <video
src="https://github.com/user-attachments/assets/d2771cb6-fe1a-4c83-9ab6-db2be421d1c6"
/> |
LuizAsFight pushed a commit that referenced this pull request Jan 19, 2025
@fuel-service-user @github-actions
ci(changesets): versioning packages (#1755)
8aa814f 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## @fuels/playwright-utils@0.47.0



## fuels-wallet@0.47.0

### Minor Changes

- [#1764](#1764)
[`d81ee482`](d81ee48)
Thanks [@helciofranco](https://github.com/helciofranco)! - Add current
account connection status to the header

- [#1762](#1762)
[`2460beef`](2460bee)
Thanks [@helciofranco](https://github.com/helciofranco)! - Add a
separate NFTs tab to the home screen.

- [#1710](#1710)
[`4c530078`](4c53007)
Thanks [@nelitow](https://github.com/nelitow)! - Improve handling of
custom assets.

### Patch Changes

- [#1778](#1778)
[`6ddb0014`](6ddb001)
Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - fix: review
button entering on loading state after getting ready to approve

- [#1725](#1725)
[`28628cbd`](28628cb)
Thanks [@nelitow](https://github.com/nelitow)! - Allow editing network
name when adding.

- [#1778](#1778)
[`6ddb0014`](6ddb001)
Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: remove
intentional longer loading states to avoid blinking.

-   Updated dependencies \[]:
    -   @fuel-wallet/connections@0.47.0
    -   @fuels/playwright-utils@0.47.0

## @fuel-wallet/connections@0.47.0



## @fuel-wallet/types@0.47.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas

@nelitow nelitow Awaiting requested review from nelitow

@arthurgeron arthurgeron Awaiting requested review from arthurgeron

Assignees

@helciofranco helciofranco

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create NFT tab for balances in Home Screen
3 participants
@helciofranco @arthurgeron @LuizAsFight