feat: improve nft support + dont send funds to assetId #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LuizAsFight
commented
Nov 6, 2024
•
LuizAsFight
commented
- Don't allow sending funds to assetId
- Improve logic of getting nft data
- Fix flaky test on transaction approval due to button entering/leaving loading state
LuizAsFight
requested review from
luizstacio,
pedronauck,
helciofranco,
arthurgeron,
rodrigobranas and
nelitow
as code owners
arthurgeron
reviewed
Nov 7, 2024
|
|
||
| if (assetCached) { | ||
| return ctx.createError({ | ||
| message: `You can't send to Asset address`, |
There was a problem hiding this comment.
I'd rather say "This address is an Asset. Your funds will be lost."
LuizAsFight
pushed a commit
that referenced
this pull request
Nov 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @fuels/playwright-utils@0.41.1 ## fuels-wallet@0.41.1 ### Patch Changes - [#1648](#1648) [`e63d6eba`](e63d6eb) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: improve nft support + dont allow sending funds to assetId address - Updated dependencies \[]: - @fuel-wallet/connections@0.41.1 - @fuels/playwright-utils@0.41.1 ## @fuel-wallet/types@0.41.1 ### Patch Changes - [#1648](#1648) [`e63d6eba`](e63d6eb) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - feat: improve nft support + dont allow sending funds to assetId address ## @fuel-wallet/connections@0.41.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.