Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky e2e contract tests #1640

Merged
merged 6 commits into from
Oct 29, 2024
Merged

fix: flaky e2e contract tests #1640

merged 6 commits into from
Oct 29, 2024

Conversation

arthurgeron
Copy link
Contributor

  • Contract tests now display:
    • Connection status
    • Contract call errors below each field
  • Buttons are now disabled when required data is not present
  • Replaced timeouts with expect.poll using new visual indicators

@arthurgeron arthurgeron marked this pull request as ready for review October 29, 2024 00:31
@arthurgeron arthurgeron enabled auto-merge (squash) October 29, 2024 00:59
@arthurgeron arthurgeron merged commit d6a9426 into master Oct 29, 2024
14 of 15 checks passed
@arthurgeron arthurgeron deleted the ag/feat/fe-867 branch October 29, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@pedronauck pedronauck Awaiting requested review from pedronauck

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

@nelitow nelitow Awaiting requested review from nelitow nelitow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurgeron @LuizAsFight