-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refact assets #1492
Merged
Merged
feat: refact assets #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuizAsFight
requested review from
luizstacio,
pedronauck,
helciofranco,
arthurgeron and
rodrigobranas
as code owners
September 21, 2024 06:06
arthurgeron
approved these changes
Sep 21, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Sep 25, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## @fuels/playwright-utils@0.30.0 ### Minor Changes - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - pump ### Patch Changes - [#1494](#1494) [`9c7f3b1a`](9c7f3b1) Thanks [@leocourbassier](https://github.com/LeoCourbassier)! - - Added pnpm build to the publish action, ensuring "dist" folder will be published ## fuels-wallet@0.30.0 ### Minor Changes - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - refactor assets related code of application ### Patch Changes - [#1493](#1493) [`4bd3f8f7`](4bd3f8f) Thanks [@arthurgeron](https://github.com/arthurgeron)! - Improve design of alerts in submitted transactions - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - fix bugs when formatting / creating values with zero units (unknown tokens) - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - make all unknown tokens / assets use default as zero units - [#1498](#1498) [`698c272c`](698c272) Thanks [@arthurgeron](https://github.com/arthurgeron)! - Avoid duplicating instances of injected Content Script - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - include hooks and helpers to deal with assets, like `useFuelAsset`, `getAssetFuelCurrentChain`, `getFuelAssetByAssetId` - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - Send screen: enable sending unknown tokens as well - [#1492](#1492) [`76c88c40`](76c88c4) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - upgrade database to remove assetId from primaryKey of assets table - Updated dependencies \[[`698c272c`](698c272)]: - @fuel-wallet/connections@0.30.0 ## @fuel-wallet/connections@0.30.0 ### Patch Changes - [#1498](#1498) [`698c272c`](698c272) Thanks [@arthurgeron](https://github.com/arthurgeron)! - Fixed extension not being detected as installed after inactivity period. ## @fuel-wallet/types@0.30.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors all assets related code of application, aiming to have stable formatting and always correct asset address + decimal config depending on current network chainId.
The previous implementation was made to work always with same chainId, thus needed to upgrade now to support multi chainId
Changes
useFuelAsset
,getAssetFuelCurrentChain
,getFuelAssetByAssetId