Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add/select network flow #1468

Merged
merged 47 commits into from
Sep 17, 2024

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Sep 10, 2024


📷 Demo
Screen.Recording.2024-09-12.at.11.40.12.mov

@luizstacio
Copy link
Member

@helciofranco On the specs of the connectors, we have two different methods for adding and another for selecting a network. https://github.com/FuelLabs/fuel-connectors/wiki.

The behaviors I think would be;

  1. Dapp can request add a new network, once this is done it also switches the network. This is done by providing a network URL that does not exist.
  2. For know network chainIds (that already exists) the DApp will need to;
    2.1 Do a selectNetwork we can allow partial data on this endpoint this means it can receive the chainId == networkId or network URL.
    2.2 To verify if they should call a add or select they will use networks that returns the support list of networks inside the connector.

arthurgeron
arthurgeron previously approved these changes Sep 11, 2024
@helciofranco helciofranco added the blocked Blocked by another issue label Sep 11, 2024
@helciofranco helciofranco changed the title feat: add select network flow feat: add/select network flow Sep 14, 2024
arthurgeron
arthurgeron previously approved these changes Sep 15, 2024
@helciofranco helciofranco merged commit ce5925c into master Sep 17, 2024
15 checks passed
@helciofranco helciofranco deleted the hf/feat/add-switch-network-experience branch September 17, 2024 02:15
LuizAsFight pushed a commit that referenced this pull request Sep 17, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to master, this PR
will be updated.


# Releases
## fuels-wallet@0.28.0

### Minor Changes

- [#1468](#1468)
[`ce5925c9`](ce5925c)
Thanks [@helciofranco](https://github.com/helciofranco)! - Allow users
to switch to or create a network through the `selectNetwork` flow,
selecting it if it already exists or creating it if not.

### Patch Changes

- [#1469](#1469)
[`2a626b6b`](2a626b6)
Thanks [@helciofranco](https://github.com/helciofranco)! - Fix long
network URLs breaking layout by enabling word wrapping.

- [#1475](#1475)
[`ff39a99b`](ff39a99)
Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - fix: show
feedback when try to unlock with invalid password

- [#1476](#1476)
[`e555035a`](e555035)
Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - chore: add
success feedback when resetting the wallet

- [#1442](#1442)
[`32abae8c`](32abae8)
Thanks [@arthurgeron](https://github.com/arthurgeron)! - Refactored
Service Worker and Content Scripts to close running processes and
listeners correctly. Fixes memory leaks.

- Updated dependencies
\[[`32abae8c`](32abae8)]:
    -   @fuel-wallet/connections@0.28.0

## @fuel-wallet/connections@0.28.0

### Patch Changes

- [#1442](#1442)
[`32abae8c`](32abae8)
Thanks [@arthurgeron](https://github.com/arthurgeron)! - Refactored
Service Worker and Content Scripts to close running processes and
listeners correctly. Fixes memory leaks.

## @fuel-wallet/types@0.28.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update to fuels 0.94.6 [wallet sdk] A switchNetwork method
4 participants