fix: extension freezing when validating a specifically malformed network URL #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurgeron
force-pushed
the
ag/fix/network-freeze-on-network-validation
branch
from
daf1a64 to
51a95b2
Compare
arthurgeron
changed the title
arthurgeron
requested review from
luizstacio,
pedronauck,
LuizAsFight,
helciofranco and
rodrigobranas
as code owners
helciofranco
approved these changes
Sep 9, 2024
LuizAsFight
pushed a commit
that referenced
this pull request
Sep 10, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated. # Releases ## fuels-wallet@0.27.4 ### Patch Changes - [#1463](#1463) [`4fbc6955`](4fbc695) Thanks [@LuizAsFight](https://github.com/LuizAsFight)! - force providerUrl on signTransactions, instead of using directly from provider - [#1459](#1459) [`00234c0a`](00234c0) Thanks [@arthurgeron](https://github.com/arthurgeron)! - Fixed extension freezing when validating a specifically malformed network URL - Updated dependencies \[]: - @fuel-wallet/connections@0.27.4 ## @fuel-wallet/connections@0.27.4 ## @fuel-wallet/types@0.27.4 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With the previous regular expression, trying to parse a specifically malformed string would block the V8 thread (good catch @LuizAsFight!). More info on the issue can be read about here.
Changes
Closes #1460