Skip to content

Commit

Permalink
Merge branch 'master' into ag/fix/services-not-restarting
Browse files Browse the repository at this point in the history
  • Loading branch information
LuizAsFight authored Apr 17, 2024
2 parents 440dd9f + 30a6938 commit b86abca
Show file tree
Hide file tree
Showing 16 changed files with 564 additions and 684 deletions.
7 changes: 7 additions & 0 deletions .changeset/curvy-rings-sell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@fuel-wallet/connections": patch
"@fuel-wallet/types": patch
"fuels-wallet": patch
---

fix: disables auto-complete for more input fields (sending transactions, adding asset and changing password).
5 changes: 3 additions & 2 deletions .github/workflows/release-changeset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
id: changesets
uses: FuelLabs/changesets-action@main
with:
publish: pnpm changeset:release
commit: "ci(changesets): versioning packages"
title: "ci(changesets): versioning packages"
createGithubReleases: aggregate
Expand All @@ -71,7 +72,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.REPO_TOKEN }}

- name: Upload artifacts to Sentry
if: ${{ !steps.changesets.outputs.pullRequestNumber }}
if: steps.changesets.outputs.published == 'true'
run: |
pnpm sentry-cli sourcemaps inject --release ${{ env.BUILD_VERSION }} ./dist-crx
pnpm sentry-cli sourcemaps upload --release ${{ env.BUILD_VERSION }} ./dist-crx
Expand All @@ -82,7 +83,7 @@ jobs:
working-directory: ./packages/app

- name: Attach Fuel Wallet to release
if: ${{ !steps.changesets.outputs.pullRequestNumber }}
if: steps.changesets.outputs.published == 'true'
uses: softprops/action-gh-release@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const AccountForm = ({ form, isLoading }: AccountFormProps) => {
<Input isDisabled={isLoading}>
<Input.Field
{...field}
id="search-account-name"
aria-label="Account Name"
placeholder="Type account name"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export const ImportAccountForm = ({
<Input isDisabled={isLoading}>
<Input.Field
{...field}
autoComplete="off"
autoComplete="new-password"
id="search-private-key"
type="password"
aria-label="Private Key"
placeholder="Enter the private key to import from"
Expand All @@ -48,6 +49,7 @@ export const ImportAccountForm = ({
<Input isDisabled={isLoading}>
<Input.Field
{...field}
id="search-account-name"
aria-label="Account Name"
placeholder="Type account name"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ export const EditAccount = () => {
}

return (
<Box.Stack gap="$4" as="form" onSubmit={form.handleSubmit(onSubmit)}>
<Box.Stack
gap="$4"
as="form"
onSubmit={form.handleSubmit(onSubmit)}
autoComplete="off"
>
<OverlayDialogTopbar onClose={accountsHandlers.closeDialog}>
Edit Account
</OverlayDialogTopbar>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@ export const ImportAccount = () => {
}

return (
<Box.Stack gap="$4" as="form" onSubmit={form.handleSubmit(onSubmit)}>
<Box.Stack
gap="$4"
as="form"
onSubmit={form.handleSubmit(onSubmit)}
autoComplete="off"
>
<OverlayDialogTopbar onClose={accountsHandlers.closeDialog}>
Import Account
</OverlayDialogTopbar>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export function AssetForm({ form, isEditing, showOnlyId }: AssetFormProps) {
<Input>
<Input.Field
{...field}
id="search-asset-id"
aria-label="Asset ID"
placeholder="Asset ID"
/>
Expand All @@ -42,6 +43,7 @@ export function AssetForm({ form, isEditing, showOnlyId }: AssetFormProps) {
<Input>
<Input.Field
{...field}
id="search-name"
aria-label="Asset name"
placeholder="Asset name"
/>
Expand All @@ -58,6 +60,7 @@ export function AssetForm({ form, isEditing, showOnlyId }: AssetFormProps) {
<Input>
<Input.Field
{...field}
id="search-symbol"
aria-label="Asset symbol"
placeholder="Asset symbol"
/>
Expand All @@ -74,6 +77,7 @@ export function AssetForm({ form, isEditing, showOnlyId }: AssetFormProps) {
<Input>
<Input.Field
{...field}
id="search-decimals"
type="number"
min={0}
max={19}
Expand All @@ -92,6 +96,7 @@ export function AssetForm({ form, isEditing, showOnlyId }: AssetFormProps) {
<Input>
<Input.Field
{...field}
id="search-image-url"
aria-label="Asset image Url"
placeholder="Asset image URL"
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function UpsertAsset() {
}

return (
<form onSubmit={form.handleSubmit(onSubmit)}>
<form onSubmit={form.handleSubmit(onSubmit)} autoComplete="off">
<Layout title={`${isEditing ? 'Edit' : 'Add'} Asset`}>
<Layout.TopBar />
<Focus.Scope autoFocus>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ export function SearchInput({
<Input.ElementLeft element={<Icon icon={Icon.is('Search')} />} />
<Input.Field
{...props}
autoComplete="off"
type="search"
id="search-input"
/**
* Since we already have type="search" we don't need role here, but
* @fuel-ui automatically add role to input. So, we need to pass
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export function NetworkForm({ form, isEditing, isLoading }: NetworkFormProps) {
<MotionInput {...animations.slideInTop()}>
<Input.Field
{...field}
id="search-network-url"
aria-label="Network URL"
placeholder="https://node.fuel.network/graphql"
/>
Expand All @@ -75,6 +76,7 @@ export function NetworkForm({ form, isEditing, isLoading }: NetworkFormProps) {
<Input>
<Input.Field
{...field}
id="search-network-name"
aria-label="Network name"
placeholder="Name of your network..."
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export function AddNetwork() {
as="form"
gap="$4"
onSubmit={form.handleSubmit(onSubmit)}
autoComplete="off"
>
<OverlayDialogTopbar onClose={handlers.closeDialog}>
Add Network
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ export function UpdateNetwork() {
}

return (
<Box.Stack gap="$4" as="form" onSubmit={form.handleSubmit(onSubmit)}>
<Box.Stack
gap="$4"
as="form"
onSubmit={form.handleSubmit(onSubmit)}
autoComplete="off"
>
<OverlayDialogTopbar onClose={handlers.closeDialog}>
Update Network
</OverlayDialogTopbar>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export function SendSelect({
<Input size="sm">
<Input.Field
{...field}
id="address"
id="search-address"
aria-label="Address Input"
placeholder="Enter a fuel address"
/>
Expand Down
1 change: 1 addition & 0 deletions packages/app/src/systems/Send/pages/SendPage/SendPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export function SendPage() {
<form
onSubmit={form.handleSubmit(handlers.submit)}
data-testid={txRequest.txStatus}
autoComplete="off"
>
<Layout title={ctx.title} isLoading={status('loading')}>
<Layout.TopBar onBack={handlers.cancel} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export function ChangePassword() {
render={({ field }) => (
<InputPassword
{...field}
autoComplete="current-password"
autoComplete="new-password"
css={styles.input}
aria-label="Current Password"
placeholder="Type your current password"
Expand Down
Loading

0 comments on commit b86abca

Please sign in to comment.