Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve punycode deprecation notice #3537

Merged
merged 14 commits into from
Jan 6, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 3, 2025

Summary

This PR fixes most of the punycode deprecation notices for node@v22+:

Internal users

Fixed most the notices for internal users by add an override for whatwg-url on the pnpm workspace.

  • master: 311 warnings (job, raw)
  • ps/chore/fix-punycode-deprecation: 3 warnings (job, raw).

I believe the docs and docs-api still experience this due to the markdown-it dependency.

create fuels users

Fixed for users of create fuels by adding relevant overrides to the templates.

"Other" users

Any user using fuels using our package, without the overridden dependencies will experience this issue. From my investigation the graphql-request dependency is the primary culprit due to its reliance on cross-fetch. As of cross-fetch@v7 the cross-fetch dependency has been removed, although it is also now ESM only and therefore blocking the upgrade.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Jan 3, 2025
@petertonysmith94 petertonysmith94 self-assigned this Jan 3, 2025
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 1:07pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 1:07pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 1:07pm

package.json Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This PR is published in NPM with version 0.0.0-pr-3537-20250103163221

This reverts commit 18073b2.
@petertonysmith94
Copy link
Contributor Author

@petertonysmith94 Ok, so the only definitive solution is to upgrade cross-fetch to v7, which sends us to #3447, right? Adding a note on the docs sounds weird, but this PR gets us in a better place already, which is a lovely start. We can move like this and continue the conversation on #3447.

Just to clarify, I'd be upgrade to graphql-request@v7 which has dropped the cross-fetch dependency.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Coverage Report:

Lines Branches Functions Statements
77.81%(+0.01%) 70.47%(+0.02%) 75.42%(+0%) 77.77%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 87.35%
(+0.61%)
47.82%
(+4.97%)
100%
(+0%)
87.35%
(+0.61%)

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) January 6, 2025 13:25
@petertonysmith94 petertonysmith94 merged commit 10612b2 into master Jan 6, 2025
24 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/fix-punycode-deprecation branch January 6, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix punycode deprecation notice
4 participants